[SYCL] Fix 5_GPU_optimized sample #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IgorOchocki Could you please take a look at this PR and approve/merge if looks ok. Please feel free to redirect if I should ask someone else. |
IgorOchocki
approved these changes
Aug 19, 2025
|
Can this PR be merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Currently there is an out-of-bound access in last iteration of the main loop in iso3dfd kernel (5_GPU_optimized sample):
oneAPI-samples/DirectProgramming/C++SYCL/StructuredGrids/guided_iso3dfd_GPUOptimization/src/5_GPU_optimized.cpp
Line 146 in ffc4fce
prev_accis accessed out-of-bounds in the last iteration.To avoid this, don't prepare unnecessary data for the next iteration if the current iteration is the last one.
Fixes Issue#
CMPLRLLVM-69572
Type of change
How Has This Been Tested?
Verified on
Intel(R) Data Center GPU Max 1550
with gpu driver 25.05.32567.17
OS: Ubuntu 22.04
intel/llvm compiler: intel/llvm@e8c8555
Commands:
clang++ -fsycl 5_GPU_optimized.cpp -o 5_GPU_optimized
./5_GPU_optimized 256 256 256 100 256 16 16 verify
Hangs without the fix, passes verification with the fix.